On Tue, Feb 22, 2022 at 5:57 AM Andrew Lunn <andrew@xxxxxxx> wrote: > > > This series has been tested on a x86 kernel build without CONFIG_OF. > > Another kernel was also built with COMPILE_TEST and CONFIG_OF support > > to build as most drivers as possible. It was also tested on a sparx5 > > arm64 with CONFIG_OF. However, it was not tested with an ACPI > > description evolved enough to validate all the changes. > > By that, do you mean a DSD description? > > In the DT world, we avoid snow flakes. Once you define a binding, it > is expected every following board will use it. So what i believe you > are doing here is defining how i2c muxes are described in APCI. Linux kernel has already established description of I2C muxes in ACPI: https://www.kernel.org/doc/html/latest/firmware-guide/acpi/i2c-muxes.html I'm not sure we want another one. > How > SFP devices are described in ACPI. Until the ACPI standards committee > says otherwise, this is it. So you need to clearly document > this. Please add to Documentation/firmware-guide/acpi/dsd. -- With Best Regards, Andy Shevchenko
