Re: [PATCH 0/9] i2c: qcom-cci: fixes and updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On 2/17/22 9:57 PM, Wolfram Sang wrote:

Vladimir Zapolskiy (9):
   dt-bindings: i2c: qcom-cci: add QCOM SM8450 compatible
   dt-bindings: i2c: qcom-cci: add description of a vbus-supply property
   i2c: qcom-cci: don't delete an unregistered adapter
   i2c: qcom-cci: don't put a device tree node before i2c_add_adapter()
   i2c: qcom-cci: initialize CCI controller after registration of adapters
   i2c: qcom-cci: simplify probe by removing one loop over busses
   i2c: qcom-cci: simplify access to bus data structure
   i2c: qcom-cci: add support of optional vbus-supply regulators
   i2c: qcom-cci: add sm8450 compatible

Patches 3+4 are already upstream. I wonder if patches 1+9 could be
applied to for-next also? Or is the vbus-supply a hard dependency here?
Patches 6+7 could probably also be resent individually after some
rebasing.


thank you for applying the fixes, 1/9 and 9/9 are also good to be applied
for-next, there is no dependency on vbus-supply, so I would appreciate, if
you take two more changes.

As you suggested I'd start working on a generic support of such an optional
bus supplier property, I believe at the moment everything is quite clear,
I'll start from testing the previous solution, however my preference is
to connect regulator on/off to master controller pm ops rather than slave
pm ops. Additionally I am not quite satisfied with 'vbus-supply' name,
some name without a confusing starting 'v' should be preferred IMO, like
'i2c-bus-supply' or 'sda-scl-supply', name suggestions are welcome.

--
Best wishes,
Vladimir



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux