On Tue, 15 Feb 2022 18:01:25 +0800 Matt Johnston wrote: > Thanks. I'll just make sure to kthread_stop() prior to calling unregister. It > looks like the kthread needs to keep running when the interface is down to > handle MCTP release timeouts which unlock the i2c bus, so can't use ndo_stop. > > Similarly for the RX path, can I safely call netif_rx(skb) after unregister? > It looks like in that case it should be OK, since enqueue_to_backlog() tests > for netif_running() and just drops the packet. (It's running from the I2C > slave irq so can't just use a mutex). I wouldn't do it, using an object after it's unregistered is asking for trouble. RPS seems to happily dereference skb->dev. It may or may not work.
