On Mon, 2022-02-14 at 21:04 -0800, Jakub Kicinski wrote: > > > > One question, the tx thread calls netif_wake_queue() - is it safe to call > > that after unregister_netdev()? (before free_netdev) > > I don't think so. > > > I've moved the kthread_stop() to the post-unregister cleanup. > > The usual way to deal with Tx would be to quiesce the worker in > ndo_stop. Maybe keep it simple and add a mutex around the worker? > You can then take the same mutex around: Thanks. I'll just make sure to kthread_stop() prior to calling unregister. It looks like the kthread needs to keep running when the interface is down to handle MCTP release timeouts which unlock the i2c bus, so can't use ndo_stop. Similarly for the RX path, can I safely call netif_rx(skb) after unregister? It looks like in that case it should be OK, since enqueue_to_backlog() tests for netif_running() and just drops the packet. (It's running from the I2C slave irq so can't just use a mutex). Thanks, Matt
