On Tue, 8 Feb 2022 11:00:31 +0100, Wolfram Sang wrote: > > I'm still reviewing these, sorry. I only picked the first patch of the > > series so that the sp5100_tco patches would build so I could test them. > > Ah, I see. I thought more than the first patch was needed for testing. You need the full series to be on the safe side, otherwise there's a risk that the two drivers will access the same registers using different methods (legacy I/O vs MMIO) so there's no synchronization and they could step on each other's toes. However as I knew about this limitation, I was careful to not use the SMBus driver while I was testing the watchdog driver :-) -- Jean Delvare SUSE L3 Support