On Fri, Jan 21, 2022 at 2:29 PM Akhil R <akhilrajeev@xxxxxxxxxx> wrote: > > > Thanks, my comments below. > > > > > Add device_irq_get_byname() to get an interrupt by name from both the > > > ACPI table and the Device Tree. > > > > This needs to be clarified (it's not and, but or), what about: > > > > Add device_irq_get_byname() to get an interrupt by name from either > > ACPI table or Device Tree whichever has it. > Does 'whichever has it' mean a bit different here? Would it be good like this -? > > Add fwnode_irq_get_byname() to get an interrupt by name from either > ACPI table or Device Tree, whichever is used for enumeration. Yes, your variant is good. -- With Best Regards, Andy Shevchenko