On 11/29/21 6:56 PM, Wolfram Sang wrote:
On Tue, Nov 09, 2021 at 04:05:51PM +0530, lakshmi.sowjanya.d@xxxxxxxxx wrote:
From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@xxxxxxxxx>
Add support to configure HCNT, LCNT values for Fast Mode Plus and High
Speed Mode.
Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@xxxxxxxxx>
Applied to for-next, thanks!
+ u32 fp_lcnt;
+ u32 hs_lcnt;
u32 sda_hold;
Short question unrelated to this patch. Why are all these u32...
dev->ss_hcnt = cfg->ss_hcnt;
dev->fs_hcnt = cfg->fs_hcnt;
... and the ones in dev are u16? Wouldn't it be easier if they all had
the same type?
True, only sda_hold(_time) is u32 and other timing parameters are u16.
Lakshmi: Would you like to send a patch fixing this and get more
contributions to the driver :-)
Originally this discrepancy was introduced 2014 by the commit
8efd1e9ee3bd ("i2c: designware-pci: set ideal HCNT, LCNT and SDA hold
time value").
Jarkko
