05.10.2021 11:50, LakshmiPraveen Kopparthi пишет: >> Why i2c->freq is fixed to I2C_MAX_FAST_MODE_FREQ in >> pci1xxxx_i2c_init()? > This is the default frequency at which the adapter shall operate. This > driver is targeted for x86,X64 platforms. Could you please suggest a > way to configure the freqeuncy? For x86 it should come somewhere from ACPI info presumably, but I'm not ACPI expert. Andy may have more insight. At least you could add a clarifying comment to the code, telling why freq is fixed to the standard speed. Also, will be great if you could remove all the unused code in v2. It will make code to look cleaner and easier to follow. You will be able to add new features later on with another patch, once those features will become really needed.
