05.10.2021 11:48, LakshmiPraveen Kopparthi пишет: > On Wed, 2021-09-29 at 10:20 +0300, Dmitry Osipenko wrote: >> [Some people who received this message don't often get email from >> digetx@xxxxxxxxx. Learn why this is important at >> http://aka.ms/LearnAboutSenderIdentification.] >> >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> 29.09.2021 09:22, LakshmiPraveen Kopparthi пишет: >>> Read and Write callbacks for PCI1XXXX I2C adapter is added. >>> >>> Signed-off-by: LakshmiPraveen Kopparthi < >>> LakshmiPraveen.Kopparthi@xxxxxxxxxxxxx> >>> --- >>> drivers/i2c/busses/i2c-mchp-pci1xxxx.c | 485 >>> +++++++++++++++++++++++++ >>> 1 file changed, 485 insertions(+) >> >> Why this is a separate patch? > > I thought of splitting the driver into two patches. > 1. Contains the intialisations,ISR, supend and resume callbacks. > 2. Contains read and write functions. > If it make sense to merge these into a single patch, I will do it. Please combine it all into a single patch. In general it's better to have a single patch for new drivers since it's easier to review.
