On Wed, 2021-09-29 at 19:44 +0300, Andy Shevchenko wrote: > [Some people who received this message don't often get email from > andriy.shevchenko@xxxxxxxxxxxxxxx. Learn why this is important at > http://aka.ms/LearnAboutSenderIdentification.] > > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Wed, Sep 29, 2021 at 10:18:46AM +0300, Dmitry Osipenko wrote: > > 29.09.2021 09:22, LakshmiPraveen Kopparthi пишет: > > ... > > > return intr_handled ? IRQ_HANDLED : IRQ_NONE; > > Or turn intr_handled into "irqreturn_t ret" and return it directly. > > Or > return IRQ_RETVAL(...); Ok. I will change it. > > ... > > > > +static const struct pci_device_id pci1xxxx_i2c_pci_id_table[] = > > > { > > > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI12000_I2C_PID) }, > > > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11010_I2C_PID) }, > > > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11101_I2C_PID) }, > > > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11400_I2C_PID) }, > > > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11414_I2C_PID) }, > > If you switch to PCI_VDEVIDE, you will see how you may improve the > device ID > definitions. ok.Got it.Will change it. > > > > + {0, } > > Redundant content inside curly braces. ok. I will remove the contents inside curly braces. > > > > +}; > > > + > > Redundant blank line. ok. I will remove it. > > > > +MODULE_DEVICE_TABLE(pci, pci1xxxx_i2c_pci_id_table); > > -- > With Best Regards, > Andy Shevchenko > >
