On Wed, Sep 29, 2021 at 10:18:46AM +0300, Dmitry Osipenko wrote:
> 29.09.2021 09:22, LakshmiPraveen Kopparthi пишет:
...
> return intr_handled ? IRQ_HANDLED : IRQ_NONE;
> Or turn intr_handled into "irqreturn_t ret" and return it directly.
Or
return IRQ_RETVAL(...);
...
> > +static const struct pci_device_id pci1xxxx_i2c_pci_id_table[] = {
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI12000_I2C_PID) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11010_I2C_PID) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11101_I2C_PID) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11400_I2C_PID) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11414_I2C_PID) },
If you switch to PCI_VDEVIDE, you will see how you may improve the device ID
definitions.
> > + {0, }
Redundant content inside curly braces.
> > +};
> > +
Redundant blank line.
> > +MODULE_DEVICE_TABLE(pci, pci1xxxx_i2c_pci_id_table);
--
With Best Regards,
Andy Shevchenko
