Hi Alain
Look good to me
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@xxxxxxxxxxx>
Regards
On 9/20/21 5:21 PM, Alain Volmat wrote:
> When getting an access timeout, ensure that the bus is in a proper
> state prior to returning the error.
>
> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver")
>
> Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index ed977b6f7ab6..ad3459a3bc5e 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1712,6 +1712,7 @@ static int stm32f7_i2c_xfer(struct i2c_adapter *i2c_adap,
> i2c_dev->msg->addr);
> if (i2c_dev->use_dma)
> dmaengine_terminate_all(dma->chan_using);
> + stm32f7_i2c_wait_free_bus(i2c_dev);
> ret = -ETIMEDOUT;
> }
>
> @@ -1769,6 +1770,7 @@ static int stm32f7_i2c_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
> dev_dbg(dev, "Access to slave 0x%x timed out\n", f7_msg->addr);
> if (i2c_dev->use_dma)
> dmaengine_terminate_all(dma->chan_using);
> + stm32f7_i2c_wait_free_bus(i2c_dev);
> ret = -ETIMEDOUT;
> goto pm_free;
> }
>
--
--
~ Py MORDRET
--
