On 11.08.2021 17:41, Andy Shevchenko wrote: > On Fri, Aug 06, 2021 at 11:12:18PM +0200, Heiner Kallweit wrote: >> Setting the autosuspend delay to a negative value disables runtime pm in >> a little bit smarter way, because we need no cleanup when removing the >> driver. Note that this is safe when reloading the driver, because the >> call to pm_runtime_set_autosuspend_delay() in probe() will reverse the >> effect. See update_autosuspend() for details. > > ... > >> * BIOS is accessing the host controller so prevent it from >> * suspending automatically from now on. >> */ >> - pm_runtime_get_sync(&pdev->dev); >> + pm_runtime_set_autosuspend_delay(&pdev->dev, -1); > > I dunno if it's being discussed, but with this you effectively allow user to > override the setting. It may screw things up AFAIU the comment above. > No, this hasn't been discussed. At least not now. Thanks for the hint. This attribute is writable for the root user, so we could argue that the root user has several options to break the system anyway.
