On Fri, Aug 06, 2021 at 11:15:51PM +0200, Heiner Kallweit wrote:
> do_pci_enable_device() takes care that PCI_COMMAND_INTX_DISABLE
> is cleared if a legacy interrupt is used.
Makes sense, but needs to be tested.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-i801.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index f56060fcf..7fa06b85f 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1827,19 +1827,12 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> priv->features &= ~FEATURE_IRQ;
>
> if (priv->features & FEATURE_IRQ) {
> - u16 pcictl, pcists;
> + u16 pcists;
>
> /* Complain if an interrupt is already pending */
> pci_read_config_word(priv->pci_dev, PCI_STATUS, &pcists);
> if (pcists & PCI_STATUS_INTERRUPT)
> dev_warn(&dev->dev, "An interrupt is pending!\n");
> -
> - /* Check if interrupts have been disabled */
> - pci_read_config_word(priv->pci_dev, PCI_COMMAND, &pcictl);
> - if (pcictl & PCI_COMMAND_INTX_DISABLE) {
> - dev_info(&dev->dev, "Interrupts are disabled\n");
> - priv->features &= ~FEATURE_IRQ;
> - }
> }
>
> if (priv->features & FEATURE_IRQ) {
> --
> 2.32.0
>
>
--
With Best Regards,
Andy Shevchenko
