On Fri, Aug 06, 2021 at 11:15:15PM +0200, Heiner Kallweit wrote: > Replace the ugly cast of the return_value pointer with proper usage. > In addition use dmi_match() instead of open-coding it. ... > - acpi_get_devices(NULL, check_acpi_smo88xx_device, NULL, > - (void **)&found); > + acpi_get_devices(NULL, check_acpi_smo88xx_device, NULL, &err); > > - return found; > + return !IS_ERR(err); Shouldn't you also check the status of acpi_get_device()? -- With Best Regards, Andy Shevchenko
