Hi, On 5/26/21 1:03 AM, Daniel Scally wrote: <snip> >> 3/8 and 5/8 seem to be nice cleanups, but not really necessary. IMHO it >> would be best to park these cleanups for later and for 3/8 add the following >> where necessary for now: >> >> /* FIXME drop this once the I2C_DEV_NAME_FORMAT macro has been added to include/linux/i2c.h */ >> #ifndef I2C_DEV_NAME_FORMAT >> #define I2C_DEV_NAME_FORMAT "i2c-%s" >> #endif >> >> This is not the prettiest but it reduces all the subsys cross-deps and things >> like this have been done before for similar reasons. >> >> Likewise it would be good if you can add if (foo) as condition before any >> clkdev_drop(foo) calls in this patch-set and then merge >> 5/8 "clkdev: Make clkdev_drop() null aware" independently of this and then >> once both are in Linux tree follow-up with a cleanup patch dropping the if (foo) >> guards. > > > This is fine by me if people are happy for it to go in like that; I'll > just fix it up later. I don't expect anyone to object against these 2 small fixes going in later, if you can drop these 2 for v5 that would greatly help with untangling all the subsys dependencies. Then I can just merge an ACPI + a gpiolib-acpi immutable branch and then merge the big drivers/platform/x86 patch. Regards, Hans
