Hi, On Sat, May 1, 2021 at 5:07 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > Hi Doug, > > On Fri, Apr 30, 2021 at 11:04 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > > Pushed this one patch. Rest of the series is pending adult > > supervision. Overall summary: > > > > 1. I could probably push some of the early sn65dsi86 cleanup patches > > in this series since they have Bjorn's review and are pretty much > > no-ops / simple cleanups, but there's probably not tons gained for > > shoving those in early. > > Those look good to me as well. I'd say just apply them. > > To me it looks like up until and including patch 18? > Feel free to add my > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > On these. OK, thanks! I've just pushed these patches to drm-misc-next with your Ack: 63358e24ee79 drm/panel: panel-simple: Cache the EDID as long as we retain power 31e25395d8b7 drm/panel: panel-simple: Power the panel when reading the EDID 4318ea406e02 drm/panel: panel-simple: Remove extra call: drm_connector_update_edid_property() b137406d9679 drm/bridge: ti-sn65dsi86: If refclk, DP AUX can happen w/out pre-enable f7a5ee2cd3e2 drm/bridge: ti-sn65dsi86: Code motion of refclk management functions 9bede63127c6 drm/bridge: ti-sn65dsi86: Use pm_runtime autosuspend 5c4381eeb709 drm/panel: panel-simple: Get rid of hacky HPD chicken-and-egg code bf73537f411b drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers bef236a5206c drm/bridge: ti-sn65dsi86: Move all the chip-related init to the start f94eb8a32863 drm/bridge: ti-sn65dsi86: Cleanup managing of drvdata 3636fc25f760 drm/bridge: ti-sn65dsi86: Add local var for "dev" to simplify probe 52d54819c8ae drm/bridge: ti-sn65dsi86: Clean debugfs code dea2500a820c drm/bridge: ti-sn65dsi86: Use devm to do our runtime_disable 905d66d08d0f drm/bridge: ti-sn65dsi86: More renames in prep for sub-devices db0036db4851 drm/bridge: ti-sn65dsi86: Rename the main driver data structure Things not pushed: [v5,15/20] i2c: i2c-core-of: Fix corner case of finding adapter by node -> Can't push i2c things [v5,14/20] drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev -> Won't work without rework. See [1] [v5,19/20] drm/bridge: ti-sn65dsi86: Don't read EDID blob over DDC -> Needs Laurent and also patch 14/20 to be resolved. [v5,20/20] arm64: dts: qcom: Link the panel to the bridge's DDC bus -> Needs all the rest resolved. Let me see if I can find a way to work around the AUX channel stuff and then I'll push a v6 of just what's left. > Just to keep you busy and make sure you don't run out of work > (haha) I noticed that the gpio_chip in this driver can use > the new GPIO_REGMAP helper library with the fixes just > landed in Torvald's tree. > > At your convenience and when you think there is too little > stuff in your sn65dsi86 TODO, check out > pinctrl-bcm63xx.c for an example of select GPIO_REGMAP > made very simple (this works fine as long as they are bit > offsets starting from 0). I seem to recall you mentioning something like this. When I looked at it in the past I wasn't convinced it would be easy. See my response [2]. The rough summary is that I didn't think the helpers were happy with the pm_runtime() model that I'm using. Did I get that wrong? [1] https://lore.kernel.org/dri-devel/CAD=FV=UTmOP8LDaf-Tyx17OORQK6pJH6O_w3cP0Bu-KRYaHkYw@xxxxxxxxxxxxxx/ [2] https://lore.kernel.org/r/CAD=FV=VqD-dY=v23KYuTqy8aRNQJJzJ7h_UOcdEBYuK9X51MQQ@xxxxxxxxxxxxxx -Doug