The primary goal of this series is to try to properly fix EDID reading
for eDP panels using the ti-sn65dsi86 bridge.
Previously we had a patch that added EDID reading but it turned out
not to work at bootup. This caused some extra churn at bootup as we
tried (and failed) to read the EDID several times and also ended up
forcing us to use the hardcoded mode at boot. With this patch series I
believe EDID reading is reliable at boot now and we never use the
hardcoded mode.
This series is the logical successor to the 3-part series containing
the patch ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only
if refclk") [1] though only one actual patch is the same between the
two.
This series starts out with some general / obvious fixes and moves on
to some more specific and maybe controversial ones. I wouldn't object
to some of the earlier ones landing if they look ready.
This patch was developed agains linuxnext (next-20210416) with
drm-misc-next (as of 20210423) merged in on a sc7180-trogdor-lazor
device. To get things booting for me, I had to use Stephen's patch [2]
to keep from crashing but otherwise all the patches I needed were
here.
Primary change between v2 and v3 is to stop doing the EDID caching in
the core. I also added Andrzej's review tags.
Between v3 and v4 this series grew a whole lot. I changed it so that
the EDID reading is actually driven by the panel driver now as was
suggested by Andrzej. While I still believe that the old approach
wasn't too bad I'm still switching. Why?
The main reason is that I think it's useful in general for the panel
code to have access to the DDC bus and to be able to read the
EDID. This may allow us to more easily have the panel code support
multiple sources of panels--it can read the EDID and possibly adjust
timings based on the model ID. It also allows the panel code (or
perhaps backlight code?) to send DDC commands if they are need for a
particular panel.
At the moment, once the panel is provided the DDC bus then existing
code will assume that it should be in charge of reading the
EDID. While it doesn't have to work that way, it seems sane to build
on what's already there.
In order to expose the DDC bus to the panel, I had to solve a bunch of
chicken-and-egg problems in terms of probe ordering between the bridge
and the panel. I've broken the bridge driver into several sub drivers
to make this happen. At the moment the sub-drivers are just there to
solve the probe problem, but conceivably someone could use them to
break the driver up in the future if need be.
Between v4 and v5, high-level view of changes.
- Some of the early patches landed, so dropped from series.
- New pm_runtime_disable() fix (fixed a patch that already landed).
- Added Bjorn's tags to most patches
- Fixed problems when building as a module.
- Reordered debugfs patch and fixed error handling there.
- Dropped last patch. I'm not convinced it's safe w/out more work.
I apologize in advance for the length of this series. Hopefully you
can see that there are only so many because they're broken up into
nice and reviewable bite-sized-chunks. :-)
*** NOTE ***: my hope is to actually land patches that have been
reviewed sometime mid-to-late next week. Please shout if you think
this is too much of a rush and you know of someone who is planning to
review that needs more time.
[1] https://lore.kernel.org/r/20210304155144.3.I60a7fb23ce4589006bc95c64ab8d15c74b876e68@changeid/
[2] https://lore.kernel.org/r/161706912161.3012082.17313817257247946143@xxxxxxxxxxxxxxxxxxxxxxxxxx/
Changes in v5:
- Missing pm_runtime_disable() patch new for v5.
- Reordered to debugfs change to avoid transient issue
- Don't print debugfs creation errors.
- Handle NULL from debugfs_create_dir() which is documented possible.
- Rebased atop the pm_runtime patch, which got reordered.
- Fix module compile problems (Bjorn + kbuild bot)
- Remove useless MODULE_DEVICE_TABLE (Bjorn).
- Fix module compile problems (Bjorn + kbuild bot)
- Remove useless MODULE_DEVICE_TABLE (Bjorn).
Douglas Anderson (20):
drm/panel: panel-simple: Add missing pm_runtime_disable() calls
drm/bridge: ti-sn65dsi86: Rename the main driver data structure
drm/bridge: ti-sn65dsi86: More renames in prep for sub-devices
drm/bridge: ti-sn65dsi86: Use devm to do our runtime_disable
drm/bridge: ti-sn65dsi86: Clean debugfs code
drm/bridge: ti-sn65dsi86: Add local var for "dev" to simplify probe
drm/bridge: ti-sn65dsi86: Cleanup managing of drvdata
drm/bridge: ti-sn65dsi86: Move all the chip-related init to the start
drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into
sub-drivers
drm/panel: panel-simple: Get rid of hacky HPD chicken-and-egg code
drm/bridge: ti-sn65dsi86: Use pm_runtime autosuspend
drm/bridge: ti-sn65dsi86: Code motion of refclk management functions
drm/bridge: ti-sn65dsi86: If refclk, DP AUX can happen w/out
pre-enable
drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev
i2c: i2c-core-of: Fix corner case of finding adapter by node
drm/panel: panel-simple: Remove extra call:
drm_connector_update_edid_property()
drm/panel: panel-simple: Power the panel when reading the EDID
drm/panel: panel-simple: Cache the EDID as long as we retain power
drm/bridge: ti-sn65dsi86: Don't read EDID blob over DDC
arm64: dts: qcom: Link the panel to the bridge's DDC bus
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
drivers/gpu/drm/bridge/Kconfig | 1 +
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 767 ++++++++++++-------
drivers/gpu/drm/panel/panel-simple.c | 49 +-
drivers/i2c/i2c-core-of.c | 17 +-
5 files changed, 538 insertions(+), 297 deletions(-)
--
2.31.1.498.g6c1eba8ee3d-goog
