On 15-04-21, 14:56, Jie Deng wrote: > > On 2021/4/15 14:45, Viresh Kumar wrote: > > On 23-03-21, 10:27, Arnd Bergmann wrote: > > > I usually recommend the use of __maybe_unused for the suspend/resume > > > callbacks for drivers that use SIMPLE_DEV_PM_OPS() or similar helpers > > > that hide the exact conditions under which the functions get called. > > > > > > In this driver, there is an explicit #ifdef in the reference to the > > > functions, so > > > it would make sense to use the same #ifdef around the definition. > > Jie, > > > > I was talking about this comment when I said I was expecting a new > > version. I think you still need to make this change. > > > I didn't forget this. It is a very small change. I'm not sure if the > maintainer Wolfram > > has any comments so that I can address them together in one version. Ahh, okay then. That's fine. I have been waiting for the final version to give my Tested/reviewed by :) -- viresh
