On 13/04/21 10:52 am, Andy Shevchenko wrote: > On Mon, Mar 29, 2021 at 4:54 AM Chris Packham > <chris.packham@xxxxxxxxxxxxxxxxxxx> wrote: >> Use device managed functions an clean up error handling. > For the god sake how have you tested this? > The patch is broken. I've clearly missed the remove path in my testing. I was focused on the interrupt bevhaviour not the probe/remove which I'll make sure to check for the next round.