On Thu, Mar 25, 2021 at 04:12:48PM +0100, Daniel Gomez wrote: > Add i2c hw base address in the adapter name and when the device is > probed. Why? We have /proc/iomem for that. Sorry, I don't see value of this change. Some comments below just to let you know about style:ish issues. ... > snprintf(adap->name, sizeof(adap->name), > - "Synopsys DesignWare I2C adapter"); > + "Synopsys DesignWare I2C adapter at 0x%llx", dev->base_addr); It actually should be resource_size_t and corresponding specifier, i.e. %pa to print it. Moreover, we have %pR (and %pr) specifiers for struct resource. ... > + dev_info(&pdev->dev, "%s\n", adap->name); Unneeded noise. -- With Best Regards, Andy Shevchenko
