On 12-03-21, 13:41, Viresh Kumar wrote:
> > > > +static struct i2c_adapter virtio_adapter = {
> > > > + .owner = THIS_MODULE,
> > > > + .name = "Virtio I2C Adapter",
> > > > + .class = I2C_CLASS_DEPRECATED,
> > > What happened to this discussion ?
> > >
> > > https://lore.kernel.org/lkml/20210305072903.wtw645rukmqr5hx5@vireshk-i7/
> >
> > My understanding is that new driver sets this to warn users that the adapter
> > doesn't support classes anymore.
>
> I think the warning is relevant for old drivers who used to support
> classes and not for new ones.
>
> > I'm not sure if Wolfram can explain it more clear for you.
>
> Okay, lemme dig in a bit then.
>
> $ git grep -l i2c_add_adapter drivers/i2c/busses/ | wc -l
> 77
>
> $ git grep -l I2C_CLASS_DEPRECATED drivers/i2c/busses/
> drivers/i2c/busses/i2c-at91-core.c
> drivers/i2c/busses/i2c-bcm2835.c
> drivers/i2c/busses/i2c-davinci.c
> drivers/i2c/busses/i2c-designware-platdrv.c
> drivers/i2c/busses/i2c-mv64xxx.c
> drivers/i2c/busses/i2c-nomadik.c
> drivers/i2c/busses/i2c-ocores.c
> drivers/i2c/busses/i2c-omap.c
> drivers/i2c/busses/i2c-rcar.c
> drivers/i2c/busses/i2c-s3c2410.c
> drivers/i2c/busses/i2c-tegra.c
> drivers/i2c/busses/i2c-virtio.c
> drivers/i2c/busses/i2c-xiic.c
>
> i.e. only 13 of 77 drivers are using this flag.
>
> The latest addition among these drivers is i2c-bcm2835.c and it was
> added back in 2013 and the flag was added to it in 2014:
>
> commit 37888f71e2c9 ("i2c: i2c-bcm2835: deprecate class based instantiation")
>
> FWIW, I also checked all the new drivers added since kernel release
> v4.0 and none of them set this flag.
What happened with this ? I didn't get a reply to it and the new
version still has it.
--
viresh
