On Wed, 10 Mar 2021, Andy Shevchenko wrote: > On Wed, Mar 10, 2021 at 10:35:39AM +0000, Lee Jones wrote: > > On Mon, 08 Mar 2021, Andy Shevchenko wrote: > > > > > Instead of open coding pci_p2sb_bar() functionality we are going to > > > use generic library for that. There one more user of it is coming. > > > > > > Besides cleaning up it fixes a potential issue if, by some reason, > > > SPI bar is 64-bit. > > > > Probably worth cleaning up the English in both these sections. > > > > Instead of open coding pci_p2sb_bar() functionality we are going to > > use generic library. There is one more user en route. > > > > This is more than just a clean-up. It also fixes a potential issue > > seen when SPI bar is 64-bit. > > Thanks! > > > Also worth briefly describing what that issue is I think. > > Current code works if and only if the PCI BAR of the hidden device is inside 4G > address space. In case firmware decides to go above 4G, we will get a wrong > address. > > Does it sound good enough? Yes, that explains it, thanks. > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > --- > > > drivers/mfd/Kconfig | 1 + > > > drivers/mfd/lpc_ich.c | 20 ++++++-------------- > > > 2 files changed, 7 insertions(+), 14 deletions(-) > > > > Code looks fine: > > > > For my own reference (apply this as-is to your sign-off block): > > > > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> > > Thanks for reviewing this series, can you have a look at the earlier sent [1] > and [2]? First one has a regression fix. Yes, thanks for the nudge. These were not in my TODO list. > [1]: https://lore.kernel.org/lkml/20210302135620.89958-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u > [2]: https://lore.kernel.org/lkml/20210301144222.31290-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
