On Thu, Feb 25, 2021 at 05:11:01PM +0100, Maxime Ripard wrote: > The brcmstb_send_i2c_cmd currently has a condition that is (CMD_RD || > CMD_WR) which always evaluates to true, while the obvious fix is to test > whether the cmd variable passed as parameter holds one of these two > values. > > Reported-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> I got a feeling of deja vu... ... and, in deed, I already fixed this, too, one year ago: http://patchwork.ozlabs.org/project/linux-i2c/patch/20200426081211.10876-1-wsa+renesas@xxxxxxxxxxxxxxxxxxxx/ Dunno why it never appeared in a pull request :( I'll pick this one, now!
Attachment:
signature.asc
Description: PGP signature
