On Fri, 23 Oct 2020 at 10:27, <peng.fan@xxxxxxx> wrote:
>
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Use devm_request_threaded_irq to simplify code
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> drivers/i2c/busses/i2c-imx.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index e6f8d6e45a15..ba9d639223ec 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1216,8 +1216,8 @@ static int i2c_imx_probe(struct platform_device *pdev)
> goto rpm_disable;
>
> /* Request IRQ */
> - ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED,
> - pdev->name, i2c_imx);
> + ret = devm_request_threaded_irq(&pdev->dev, irq, i2c_imx_isr, NULL, IRQF_SHARED,
> + pdev->name, i2c_imx);
Really? You silently revert commit e50e4f0b85be ("i2c: imx: Fix
external abort on interrupt in exit paths"). This is not a
simplification but serious change. NAK. At least without proper
reasoning of why this is suddenly safe.
Best regards,
Krzysztof
Best regards,
Krzysztof
