On 10/14/20 6:53 PM, jarkko.nikula@xxxxxxxxxxxxxxx wrote: > Thanks for the patch. I was thinking this too after your report but > haven't found actually time to look at implementing it. > > But what I was thinking it is probably good to have two patches. First > patch that changes only i2c_dw_read_clear_intrbits_slave() semantics so > that it's called only once like here and second patch that does other > logic changes. Makes easier to catch possible regressions I think. > > Jarkko I can't agree with you more. I'll separate them into two patches in next version. By the way, I found a way to compile my patch by myself via "make multi_v7_defconfig" and "make drivers/i2c/busses/i2c-designware-slave.o". I've done and there were no warnings about drivers/i2c/busses/i2c-designware-slave.c:13. -- Michael Wu