> -----Original Message----- > From: Wolfram Sang <wsa@xxxxxxxxxx> > Sent: Sunday, September 27, 2020 9:57 AM > To: Khalil Blaiech <kblaiech@xxxxxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx>; linux-i2c@xxxxxxxxxxxxxxx; Khalil Blaiech > <kblaiech@xxxxxxxxxxxx>; Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Subject: Re: [PATCH v11 2/2] dt-bindings: i2c: I2C binding for Mellanox > BlueField SoC > > On Tue, Sep 22, 2020 at 06:49:38PM -0400, Khalil Blaiech wrote: > > From: Khalil Blaiech <kblaiech@xxxxxxxxxxxx> > > > > Add device tree bindings documentation for Mellanox BlueField > > I2C SMBus controller. > > > > Signed-off-by: Khalil Blaiech <kblaiech@xxxxxxxxxxxx> > > Applied to for-next, thanks! Again, thank you very much. > > A first incremental improvement could be converting this file to the > YAML format. And add the new file to your MAINTAINERS entry. Will do. Our driver supports both ACPI and devicetree. However, the platform firmware running on our platform implements ACPI and doesn't really rely on devicetree. Do you think we should keep the devicetree support? Or should I get rid of it before we apply the patch? Your feedback is much appreciated. > > All that aside, thank you for your patience and for keeping at it! Thanks.