RE: [PATCH] i2c: nvidia-gpu: use dev_info for timeout error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

> -----Original Message-----
> From: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> Sent: Monday, September 21, 2020 11:09 AM
> To: Ajay Gupta <ajaykuee@xxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx; Ajay Gupta <ajayg@xxxxxxxxxx>
> Subject: Re: [PATCH] i2c: nvidia-gpu: use dev_info for timeout error
> 
> On Mon, Sep 21, 2020 at 10:34:26AM -0700, Ajay Gupta wrote:
> > From: Ajay Gupta <ajayg@xxxxxxxxxx>
> >
> > Timeout error may be seen due to missing i2c client such as USB Type-C
> > UCSI controller on some NVIDIA GPU card. Currently we don't have a
> > correct way to identify these cards.
> >
> > Tools like Plymouth (splashscreen) doesn't like dev_err so changing
> > timeout status log to dev_info.
> >
> > Bug information:
> > https://bugzilla.kernel.org/show_bug.cgi?id=206653
> >
> > Signed-off-by: Ajay Gupta <ajayg@xxxxxxxxxx>
> 
> Hmm, a KERN_INFO message saying "error" does not make much sense.
> Maybe this is an argument to simply remove the message?
Sounds good. Client driver anyways gets probe error in case of a real i2c
timeout with an existing i2c device and that can help debug.

 Thanks
>nvpublic





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux