Hi Saheed, On Sat, 18 Jul 2020 20:45:58 +0200, Saheed Olayemi Bolarinwa wrote: > This goal of these series is to move the definition of *all* PCIBIOS* from > include/linux/pci.h to arch/x86 and limit their use within there. > All other tree specific definition will be left for intact. Maybe they can > be renamed. > > PCIBIOS* is an x86 concept as defined by the PCI spec. The returned error > codes of PCIBIOS* are positive values and this introduces some complexities > which other archs need not incur. > > PLAN: > > 1. [PATCH v0 1-36] Replace all PCIBIOS_SUCCESSFUL with 0 > (...) Thanks for the explanations. Now I understand your previous patches better, and if you fix the alignment issues I'll be happy to approve them. > Bolarinwa Olayemi Saheed (35): > Change PCIBIOS_SUCCESSFUL to 0 > Change PCIBIOS_SUCCESSFUL to 0 > Change PCIBIOS_SUCCESSFUL to 0 > (...) You'd have to prefix the patch names to make them all unique, but I think you have done that already as the patches I received looked fine in this respect. -- Jean Delvare SUSE L3 Support