Re: [PATCH] i2c: designware: Fix bus speed in !CONFIG_ACPI case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/23/20 11:47 AM, Andy Shevchenko wrote:
On Tue, Jun 23, 2020 at 11:46:35AM +0300, Andy Shevchenko wrote:
On Tue, Jun 23, 2020 at 11:31:13AM +0300, Jarkko Nikula wrote:
John Stultz reported that commit f9288fcc5c615 ("i2c: designware: Move
ACPI parts into common module") caused a regression on the HiKey board
where adv7511 HDMI bridge driver wasn't probing anymore due the I2C bus
failed to start.

It seems the change caused the bus speed being zero when CONFIG_ACPI
not set and neither speed based on "clock-frequency" device property or
default fast mode is set.

Fix this by moving bus speed setting back to dw_i2c_plat_probe() and let
the i2c_dw_acpi_adjust_bus_speed() adjust only speed from ACPI.

I have slightly different idea, I'll send a patch soon after testing.

Note, your patch breaks PCI case.

Ah, indeed. So please ignore my patch.

--
Jarkko



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux