Re: [PATCH] i2c: sh_mobile: implement atomic transfers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thank you for the review.

> On June 14, 2020 11:31 AM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> > -	pm_runtime_get_sync(pd->dev);
> > +	if (!pd->atomic_xfer)
> > +		pm_runtime_get_sync(pd->dev);
> 
> This was a small surprise to me. I assume RPM is disabled that late?
> But can we be sure the clock is on, then?

Turns out it's unnecessary to mess with PM handling here. I assumed that it must not be touched during atomic transfers, but that seems not to be the case. I'll drop that bit in the next revision.

CU
Uli



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux