Re: [PATCH 2/5] i2c: xiic: Drop broken interrupt handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

On Sat, Jun 13, 2020 at 8:39 PM Marek Vasut <marex@xxxxxxx> wrote:
>
> The interrupt handler is missing locking when reading out registers
> and is racing with other threads which might access the driver. Drop
> it altogether, so that the threaded interrupt is always executed, as
> that one is already serialized by the driver mutex. This also allows
> dropping local_irq_save()/local_irq_restore() in xiic_start_recv().
>
The idea of the local_irq_save / restore was to make it atomic in case
there are a lot
of non i2c interrupts.

so it should still be needed right?



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux