Re: [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > -	addr_info->added_client = i2c_new_device(to_i2c_adapter(adev),
> > -						 &addr_info->binfo);
> > +	addr_info->added_client = i2c_new_client_device(to_i2c_adapter(adev),
> > +							&addr_info->binfo);
> 
> i2c_new_client_device returns an ERR_PTR, not NULL on error.  So this

Yes, this is the main motivation for the new API.

> needs some more work.  I'll send something out soon.

Why does it need that work? 'added_client' is only used with
i2c_unregister_device() which has been fixed to handle ERR_PTR as well.
Or am I missing something?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux