Re: [PATCH v3 3/4] i2c: mux: pca954x: Move device_remove_file() out of pca954x_cleanup()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-04-25 13:51, Andy Shevchenko wrote:
> device_create_file() is called the last in ->probe() but pca954x_cleanup(),
> which is called earlier in error path, tries to remove never created file.
> Move device_remove_file() call outside of pca954x_cleanup() to make it
> slightly closer to what pca954x_init() is doing.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Peter Rosin <peda@xxxxxxxxxx>

Cheers,
Peter




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux