On second look, two questions:
> + if (!error) {
> + int ret = request_firmware_into_buf(&fw, eeprom_data, &client->dev,
> + eeprom->buffer, size);
> + if (ret)
> + return ret;
Aren't we leaking 'fw' here?
Also, do we need 'error' and 'ret'? Can't we reuse one of them?
> + release_firmware(fw);
Attachment:
signature.asc
Description: PGP signature
