On Tue, 21 Apr 2020 11:37:13 +0200 Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > On Wed, Apr 15, 2020 at 06:49:14PM +0530, Aishwarya R wrote: > > >> Use of_property_read_u32 to read the "reg" and "i2c-address" property > > >> instead of using of_get_property to check the return values. > > >> > > >> Signed-off-by: Aishwarya R <aishwaryarj100@xxxxxxxxx> > > > > > This is quite a fragile driver. Have you tested it on HW? > > > > This change is not tested with the Hardware. > > But of_property_read_u32 is better here than generic of_get_property. > > This make sure that value read properly independent of system endianess. > > This driver is only used on PPC_BE. And it is *very* fragile. The gain > is not enough for me to accept it without testing. Maybe Erhard (CCed) > is interested. If not, you may find someone on the ppc lists. > I applied the patch on top of kernel 5.6.6 and tested it on a PowerMac G4 3,6 DP and a PowerMac G5 11,2. Both machines run without anything suspicious going on. dmesg | grep i2c looks the same with patch and without patch. Tested-by: Erhard Furtner <erhard_f@xxxxxxxxxxx>
