Hi Wolfram,
On Wed, Apr 15, 2020 at 01:01:45PM +0200, Wolfram Sang wrote:
> > if (IS_ERR(dma->chan_tx)) {
> > - dev_dbg(dev, "can't request DMA tx channel\n");
> > ret = PTR_ERR(dma->chan_tx);
> > + if (ret != -EPROBE_DEFER)
> > + dev_dbg(dev, "can't request DMA tx channel\n");
>
> dev_dbg for tx...
Intention was to not change too much the original code when introducing this
check and fixing this message level in another patch. But I guess indeed this
can be done all at once.
I am pushing a v2 fixing this in this patch and having dev_err for both tx & rx
dma requests.
>
> > goto fail_al;
> > }
> >
> > @@ -44,8 +45,10 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> > /* Request and configure I2C RX dma channel */
> > dma->chan_rx = dma_request_chan(dev, "rx");
> > if (IS_ERR(dma->chan_rx)) {
> > - dev_err(dev, "can't request DMA rx channel\n");
> > ret = PTR_ERR(dma->chan_rx);
> > + if (ret != -EPROBE_DEFER)
> > + dev_err(dev, "can't request DMA rx channel\n");
>
> ... and dev_err for rx? Intentional?
>
