Hi Khalil, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on robh/for-next linus/master v5.6-rc7 next-20200327] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Khalil-Blaiech/i2c-add-driver-for-Mellanox-BlueField-SoC/20200328-042750 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/i2c/busses/i2c-mlxbf.c: In function 'mlxbf_i2c_get_gpio': >> drivers/i2c/busses/i2c-mlxbf.c:1288:17: error: implicit declaration of function 'devm_ioremap_nocache'; did you mean 'devm_ioremap_release'? [-Werror=implicit-function-declaration] 1288 | gpio_res->io = devm_ioremap_nocache(dev, params->start, size); | ^~~~~~~~~~~~~~~~~~~~ | devm_ioremap_release drivers/i2c/busses/i2c-mlxbf.c:1288:15: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1288 | gpio_res->io = devm_ioremap_nocache(dev, params->start, size); | ^ drivers/i2c/busses/i2c-mlxbf.c: In function 'mlxbf_i2c_get_corepll': drivers/i2c/busses/i2c-mlxbf.c:1353:18: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1353 | corepll_res->io = devm_ioremap_nocache(dev, params->start, size); | ^ drivers/i2c/busses/i2c-mlxbf.c: In function 'mlxbf_i2c_init_coalesce': drivers/i2c/busses/i2c-mlxbf.c:1755:22: error: implicit declaration of function 'ioremap_nocache'; did you mean 'ioremap_cache'? [-Werror=implicit-function-declaration] 1755 | coalesce_res->io = ioremap_nocache(params->start, size); | ^~~~~~~~~~~~~~~ | ioremap_cache drivers/i2c/busses/i2c-mlxbf.c:1755:20: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1755 | coalesce_res->io = ioremap_nocache(params->start, size); | ^ cc1: some warnings being treated as errors vim +1288 drivers/i2c/busses/i2c-mlxbf.c 1258 1259 static int mlxbf_i2c_get_gpio(struct platform_device *pdev, 1260 struct mlxbf_i2c_priv *priv) 1261 { 1262 struct mlxbf_i2c_resource *gpio_res; 1263 struct device *dev = &pdev->dev; 1264 struct resource *params; 1265 resource_size_t size; 1266 1267 gpio_res = mlxbf_i2c_get_shared_resource(priv, MLXBF_I2C_GPIO_RES); 1268 if (!gpio_res) 1269 return -EPERM; 1270 1271 /* 1272 * The GPIO region in TYU space is shared among I2C busses. 1273 * This function MUST be serialized to avoid racing when 1274 * claiming the memory region and/or setting up the GPIO. 1275 */ 1276 lockdep_assert_held(gpio_res->lock); 1277 1278 /* Check whether the memory map exist. */ 1279 if (gpio_res->io) 1280 return 0; 1281 1282 params = gpio_res->params; 1283 size = resource_size(params); 1284 1285 if (!devm_request_mem_region(dev, params->start, size, params->name)) 1286 return -EFAULT; 1287 > 1288 gpio_res->io = devm_ioremap_nocache(dev, params->start, size); 1289 if (IS_ERR(gpio_res->io)) { 1290 devm_release_mem_region(dev, params->start, size); 1291 return PTR_ERR(gpio_res->io); 1292 } 1293 1294 return 0; 1295 } 1296 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
