On Sat, Mar 21, 2020 at 07:33:49PM +0100, Wolfram Sang wrote: > On Fri, Mar 06, 2020 at 04:19:58PM +0300, Sergey.Semin@xxxxxxxxxxxxxxxxxxxx wrote: > > From: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > > > > A third I2C controller embedded into the Baikal-T1 SoC is also fully > > based on the DW APB I2C core, but its registers are indirectly > > accessible via "command/data in/data out" trio. There is no difference > > other than that. So in order to have that controller supported by the > > common DW APB I2C driver we only need to introduce a new flag > > ACCESS_INDIRECT and use the access-registers to reach the I2C controller > > normal registers space in the dw_readl/dw_writel methods. Currently this > > flag is only enabled for the controllers with "be,bt1-i2c" compatible > > string. > > > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx> > > Patches 2,3, and 6 have comments which should be addressed. Patches 4+5 > can be dropped when sending next version. > Great! Thanks. I'll have respond on the requests very soon. Regards, -Sergey