On Fri, Mar 20, 2020 at 09:23:42AM +0100, Alain Volmat wrote:
> On Mon, Mar 16, 2020 at 05:49:27PM +0200, Andy Shevchenko wrote:
> > Switch to the new generic functions: i2c_parse_fw_timings().
> >
> > While here, replace hard coded values with standard bus frequency definitions.
...
> > static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev,
> > struct stm32f7_i2c_setup *setup)
> > {
> > + i2c_parse_fw_timings(&pdev->dev, t, false);
>
> Andy, thanks for the patch.
> Looks fine overall, apart from the above line which should be
>
> i2c_parse_fw_timings(i2c_dev->dev, t, false);
Oh, good catch!
If I read the code correctly it's an equivalent, but I see that we don't supply pdev.
I will fix it for v4.
--
With Best Regards,
Andy Shevchenko
