On Fri, Mar 06, 2020 at 12:10:49PM +0200, Andy Shevchenko wrote: > On Thu, Mar 05, 2020 at 09:58:29PM +0000, Peter Rosin wrote: > > On 2020-02-27 13:21, Andy Shevchenko wrote: ... > > > +/* I2C Frequency Modes */ > > > +#define I2C_MAX_STANDARD_MODE_FREQ 100000 > > > +#define I2C_MAX_FAST_MODE_FREQ 400000 > > > +#define I2C_MAX_FAST_PLUS_MODE_FREQ 1000000 > > > +#define I2C_MAX_TURBO_MODE_FREQ 1400000 > > > +#define I2C_MAX_HIGH_SPEED_MODE_FREQ 3400000 > > > +#define I2C_MAX_ULTRA_SPEED_MODE_FREQ 5000000 > > I can't seem to > > remember what frequency TURBO, HIGH, etc are and their ordering is > > difficult. It's all sounds like marketing buzz to me and my brain shuts > > off instantly. > > > > This feels a lot like moving away from octal permissions for files, which > > is frowned upon... > > > > Can we include some kind of indication of the actual frequency in the > > names as well please? > > > > Perhaps something like I2C_MAX_STANDARD_MODE_100KHZ? > > It's definitely a duplicate information here. > > In I²C we have quite established range of frequencies (4 out of 6 in above > list), so, their names already implying very well defined frequencies. Actually 5 out of 6. In new version (just sent) I put a link to Wiki. -- With Best Regards, Andy Shevchenko
