Hi Geert, On 13/11/19 11:14, Geert Uytterhoeven wrote: > Variable "rate" already contains the current clock rate, so use that > rather than calling clk_get_rate() again. > > Fixes: 8d0494037bb2af32 ("i2c: rcar: get clock rate only once and simplify calculation") Not sure this should be considered a fix. The code is not broken, it's only non-optimal. But anyway, with or without the "Fixes" line: Reviewed-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx> -- Luca