Re: [PATCH] i2c: rcar: Remove superfluous call to clk_get_rate()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On 13/11/19 11:14, Geert Uytterhoeven wrote:
> Variable "rate" already contains the current clock rate, so use that
> rather than calling clk_get_rate() again.
> 
> Fixes: 8d0494037bb2af32 ("i2c: rcar: get clock rate only once and simplify calculation")

Not sure this should be considered a fix. The code is not broken, it's
only non-optimal.

But anyway, with or without the "Fixes" line:

Reviewed-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>

-- 
Luca



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux