Re: [PATCH] i2c: icy: no need to populate address for scanned device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/06/2019 04:02 PM, Wolfram Sang wrote:
> Max, if you have a minute, could you test this (and the
> i2c_new_scanned_device conversion) on your HW? Would be much
> appreciated. Thanks!

[...snip...]


> diff --git a/drivers/i2c/busses/i2c-icy.c b/drivers/i2c/busses/i2c-icy.c
> index 07baa4d8de39..271470f4d8a9 100644
> --- a/drivers/i2c/busses/i2c-icy.c
> +++ b/drivers/i2c/busses/i2c-icy.c
> @@ -122,7 +122,6 @@ static int icy_probe(struct zorro_dev *z,
>  	struct fwnode_handle *new_fwnode;
>  	struct i2c_board_info ltc2990_info = {
>  		.type		= "ltc2990",
> -		.addr		= 0x4c,

Thanks for catching this!

Looking at the I2C probe/scan code as well as i2c-icy, I see no reason for this to go wrong, so have an ACK from me.

I can test this tomorrow or on Friday if you insist, just not today. I've just set up my Amiga again.


Max



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux