Re: [PATCH] eeprom: at24: Improve confusing log message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



pt., 4 paź 2019 o 10:43 Wolfram Sang <wsa@xxxxxxxxxxxxx> napisał(a):
>
> On Fri, Oct 04, 2019 at 10:37:48AM +0200, Jean Delvare wrote:
> > Currently when binding to an spd EEPROM, the at24 drivers logs the
> > following message:
> >
> > 256 byte spd EEPROM, read-only, 0 bytes/write
> >
> > The last part is confusing, as by definition you don't write to a
> > read-only EEPROM, plus "0 bytes/write" makes no sense whatsoever.
> >
> > I propose to have a different message for read-only EEPROMs, which
> > does not include this last part.
> >
> > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
>
> I like it!
>
> Reviewed-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
>

Me too. Applied right away.

Bart




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux