On Tue, Oct 01, 2019 at 11:39:10AM -0500, Patrick Williams wrote: > Thanks for the review Andy. > > On Tue, Oct 01, 2019 at 07:29:13PM +0300, Andy Shevchenko wrote: > > > > > > On Tue, Oct 01, 2019 at 10:59:59AM -0500, Patrick Williams wrote: > > There are quite a few people in the Cc list. I'm not sure they all are > > interested in this. I deliberately dropped few names, sorry, if I was mistaken. > > Agree it was kind of a big list. Just chose what was given to me by > get_maintainer.pl. It seems like there isn't a direct identified > maintainer of this file. Hint: `scripts/get_maintainer.pl --git --git-min-percent=67 ...` > > > + i2c_slave_event(i2c->slave, I2C_SLAVE_READ_REQUESTED, > > > + &byte); > > > + i2c_slave_event(i2c->slave, I2C_SLAVE_WRITE_REQUESTED, > > > + NULL); > The two different paths also require READ_REQUEST vs WRITE_REQUESTED. I > could do a ternary there but it seemed more obvious to just unroll the > logic. Ah, I see now. -- With Best Regards, Andy Shevchenko
