On Fri, Sep 27, 2019 at 10:06 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > > pt., 27 wrz 2019 o 15:42 Rob Herring <robh@xxxxxxxxxx> napisał(a): > > > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > > > Convert the binding document for at24 EEPROMs from txt to yaml. The > > compatible property uses a regex pattern to address all the possible > > combinations of "vendor,model" strings. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > [robh: rework compatible schema, fix missing allOf for $ref, fix errors in example] > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > v4: > > - Add a $nodename definition > > > > - Turns out the compatible schema is too complex for generating a 'select' > > schema and only a small subset where getting validated. So we need a > > custom 'select' schema. This in turn fixes the issue with the nxp,se97b > > binding. > > Thanks again! > > > > > Now we get a different set of errors checking Arm dts files (omitting > > a bunch of node name ones): > > > > > arch/arm/boot/dts/at91-dvk_som60.dt.yaml: eeprom@57: compatible: ['giantec,gt24c32a', 'atmel,24c32'] is not valid under any of the given schemas > > This is because nobody bothered adding 'giantec,gt24c32a' to previous > .txt bindings. I'll add this in a follow-up patch. > > > arch/arm/boot/dts/am3874-iceboard.dt.yaml: at24cs01@5f: compatible: ['atmel,24cs01'] is not valid under any of the given schemas > > arch/arm/boot/dts/am3874-iceboard.dt.yaml: at24cs08@5c: compatible: ['atmel,24cs08'] is not valid under any of the given schemas > > > > These look fine at first glance, I'm not sure what the problem here > is. I'll take a look at these as soon as I can. Ah, that's my mistake. I guess there's only no 24cs00 variant. Rob
