Re: [v2 0/3] Fix issues reported by Coccinelle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 17, 2019 at 08:14:23PM +0200, Wolfram Sang wrote:
> On Tue, Sep 17, 2019 at 08:10:45PM +0200, Markus Elfring wrote:
> > > Using cocciecheck to ensure there are no semantic issues in
> > > i2c-qup driver.
> > 
> > * This wording contains a typo.
> 
> Doesn't matter to me for a cover letter as long as we can understand it.
> 
> > * I would prefer to refer to a desired reduction of a few
> >   source code quality concerns.
> 
> Not needed. I understand what is going on here.

Markus - By "ensure", I mean there are no further cocciecheck issues at this
point in time. And further, what changed is covered in individual patch
changelog. So, I think this information is fine in cover.

> > Can such a prefix be omitted?
Can be, but I like to keep it.

Thanks for review.

-Saiyam



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux