> > What about:
> >
> > if (!eeprom->read_only) {
> > spin_lock(&eeprom->buffer_lock);
> > eeprom->buffer[eeprom->buffer_idx++ & eeprom->address_mask] = *val;
> > spin_unlock(&eeprom->buffer_lock);
> > }
> >
> > We can still keep only one exit point from the function this way.
>
>
> Yes, that is better, I will fix tomorrow.
Thanks!
> > "ro" missing. You haven't tested this entry ;)
> >
>
> Guilty! I discovered when I was about to send the patch that I’ve
> missed that eeprom, so I added it there. But I discovered my error
> when I backported it to our system:-)
:) I found v2 afterwards where you fixed this already.
When sending v3, please use this prefix in $subject:
"i2c: slave-eeprom:"
'git log <file>' helps to see what are the subsystems preferences for
prefixes.
Attachment:
signature.asc
Description: PGP signature
