Re: [PATCH] i2c-eeprom_slave: Add support for more eeprom models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9/4/19 5:48 PM, Wolfram Sang wrote:

I am not sure if this is a behavior that is worth trying to mimic?
Not yet. We can add this incrementally once we know most EERPOMs behave
like this. It could be worth adding a comment, though, like:

/*
  * FIXME: What to do if only 8 bits of a 16 bit address are sent?
  * The <your vendor & eeprom type> sends only 0xff then. Needs verification
  * with other EEPROMs, though. We currently use the 8 bit as a valid
  * address.
  */


The eeprom tested is from ST, model M24C64. Should this be added in the code or in some doc folder?


I have another question. I'm considering adding a flag to set the virtual eeprom in read-only mode on the i2c side (but writable from the sysfs side). Should this be implemented as a separate i2c_device_id, or by trying to read som configuration flag from devicetree?


/BA




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux