Hi Björn,
please add versioning to your patch updates. git-format-patch makes it
easy using the '-v' parameter.
On Tue, Sep 03, 2019 at 09:51:31AM +0200, Björn Ardö wrote:
> Add a 32 and a 64 kbit memory. These needs 16 bit address
> so added support for that as well.
>
> Signed-off-by: Björn Ardö <bjorn.ardo@xxxxxxxx>
> ---
And also please provide a short changelog here. What did you change
since last version. There are so many patches, I can't remember every
patch.
> @@ -19,14 +20,21 @@
> #include <linux/spinlock.h>
> #include <linux/sysfs.h>
>
> +
Unrelated change. If you use 'checkpatch --strict', it will warn about
it.
> + if (eeprom->idx_write_cnt < eeprom->num_address_bytes) {
> + if (eeprom->idx_write_cnt == 0)
> + eeprom->buffer_idx = 0;
Yes, I think the code is nicely readable now.
Rest of the code looks good!
Did you have a chance to test the real EEPROM yet (not mandatory for the
acceptance of this patch, of course)
Happy hacking,
Wolfram
Attachment:
signature.asc
Description: PGP signature
